test: generate bound model methods tests #546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jooola
force-pushed
the
generate-bound-model-tests
branch
from
686fce8 to
dfa9389
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #546 +/- ##
==========================================
+ Coverage 95.82% 96.58% +0.76%
==========================================
Files 67 67
Lines 3401 3401
==========================================
+ Hits 3259 3285 +26
+ Misses 142 116 -26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jooola
force-pushed
the
generate-bound-model-tests
branch
3 times, most recently
from
77559ad to
965e21b
Compare
jooola
force-pushed
the
generate-bound-model-tests
branch
from
965e21b to
e50082d
Compare
Member
Author
|
Depends on #564 |
jooola
force-pushed
the
generate-bound-model-tests
branch
2 times, most recently
from
144860b to
04dee98
Compare
jooola
added a commit
that referenced
this pull request
Oct 2, 2025
jooola
force-pushed
the
generate-bound-model-tests
branch
from
04dee98 to
5ceab8e
Compare
Member
Author
|
The diff on this MR is really large, but the important bits are in f0b3622 To further check this PR is valid, I recommend looking at the coverage report and see that "nothing" changed. |
jooola
force-pushed
the
generate-bound-model-tests
branch
from
5ceab8e to
95940a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our bound models, many of the methods are only proxies to the api client methods. But our tests are always testing the full stack down to the HTTP requests. This lead to a lot of duplicate tests for the API client and the bound models methods.
This change removes the bound models methods tests, and uses a generic "proxy method test" for all our bound models.